linux-kernel - Re: [PATCH] printk: Fix discarding of records

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Feb 2014 21:38:22 -0500
From:	"Banerjee, Debabrata" <dbanerje@...mai.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Kay Sievers <kay.sievers@...y.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jeff Mahoney <jeffm@...e.com>,
	"dbavatar@...il.com" <dbavatar@...il.com>,
	"Hunt, Joshua" <johunt@...mai.com>, stable <stable@...r.kernel.org>
Subject: Re: [PATCH] printk: Fix discarding of records

On 2/16/14, 7:41 PM, "Linus Torvalds" <torvalds@...ux-foundation.org>
wrote:

>On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata
><dbanerje@...mai.com> wrote:
>>
>> No that can't be right, the prev value after every loop is the
>>msg->flags
>> from the *last* line in the list, which has no relation to the *first*,
>>so
>> reusing it for the top of the next loop is nonsense.
>
>Please, Debabrata, humor me, and just try the patch.
>
>And try reading the source code. Because your statement is BS.
...
>No, I haven't tested my patch, and maybe it's broken for some subtle
>reason I'm missing too.

Yes my explanation was wrong, your patch works for me. I assumed printing
the prefix was desired, but if not, great.

-Debabrata


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/