linux-kernel - Re: [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding style issues in hwdrv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Feb 2014 13:59:44 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Chase Southwood <chase.southwood@...oo.com>
Cc:	Ian Abbott <abbotti@....co.uk>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding
 style issues in hwdrv_apci035.c

On Mon, Feb 17, 2014 at 12:45:07PM -0800, Chase Southwood wrote:
> >On Monday, February 17, 2014 7:16 AM, Ian Abbott <abbotti@....co.uk> wrote:
> 
> >>On 2014-02-16 08:40, Chase Southwood wrote:
> >> This patch for hwdrv_apci035 removes some unneeded braces, and moves some
> >> improperly placed braces to the correct position, as found by checkpatch.
> >> It also removes a commented out if-statement that I found whilst cleaning
> >> braces that is identical to another un-commented if-statement directly
> >> above it, so it is just added clutter and so we can delete it to clean up
> >> further.
> >>
> >> Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
> >> ---
> >> So I decided to venture into addi-data today and found that most of the
> >> files in there are very messy from a style standpoint.  This is the first
> >> (of probably a few) patchsets to try and clean those files up a bit.  I
> >> hope that this will be helpful!
> >
> >Quite a few have been cleaned up extensively by Hartley, but they needed 
> >more extensive changes than clean-ups due to them trying to handle 
> >things differently to the normal comedi way of doing things.
> 
> Oh, I see.  Makes perfect sense.  Well like I said, if cleaning them
> up a bit will help make reworking them any easier or seems like useful
> work, I'd be happy to continue making them a little easier on the
> eyes!

Ian acked your patch already...  If you want to clean these up then go
for it.  There is no reason Hartley should have to do all the work.

But consider doing more "extensive" cleanups.  Instead of just shifting
the comments over in [patch 2/4] you could change the format to kernel
style.  Newbies are too timid.  Look through the work that Hartley has
done and try copy it.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/