[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140218163705.GD30043@htj.dyndns.org>
Date: Tue, 18 Feb 2014 11:37:05 -0500
From: Tejun Heo <tj@...nel.org>
To: Peter Hurley <peter@...leysoftware.com>
Cc: Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
Stefan Richter <stefanr@...6.in-berlin.de>,
stable@...r.kernel.org
Subject: Re: [PATCH] workqueue: Document exceptions to work item
non-reentrancy guarantee
On Tue, Feb 18, 2014 at 11:31:18AM -0500, Peter Hurley wrote:
> >It's a pretty dumb thing to do anyway.
>
> Fragile, yes; dumb, no. At least not from the point-of-view of the
> documentation and what the workqueue actually did. But obviously from
> your reaction, unintentional design.
Well, maybe dumb is too strong a word but these types of edge case
interfaces tend to cause subtle issues over time while being
marginally useful at best. Sure it helps a couple odd users to write
slightly less code, but that's such a marginal gain compared to the
fragility it adds by being another one-off thing. So, yeah, it's a
silly thing to include in an interface as widely use as workqueue and
it's more of a historical remanant than anything else at this point.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists