linux-kernel - Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Feb 2014 13:47:16 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, dhowells <dhowells@...hat.com>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

On Thu, 20 Feb 2014 22:00:39 +0800 Fabian Frederick <fabf@...net.be> wrote:

> This patch calls zalloc for explicit zero fill and removes all memset 0.
> 

May as well fix the deceitful comment while we're in there.

--- a/fs/afs/super.c~afs-afs_alloc_inode-use-kmem_cache_zalloc-fix
+++ a/fs/afs/super.c
@@ -474,7 +474,7 @@ static void afs_i_init_once(void *_vnode
 }
 
 /*
- * allocate an AFS inode struct from our slab cache
+ * allocate an AFS inode struct
  */
 static struct inode *afs_alloc_inode(struct super_block *sb)
 {

This isn't the most useful comment in the kernel..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/