linux-kernel - Re: [PATCH v3 10/11] watchdog: xilinx: Enable this driver for Zynq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Feb 2014 19:44:19 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	linux-kernel@...r.kernel.org, monstr@...str.eu, linux@...ck-us.net,
	linux-watchdog@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 10/11] watchdog: xilinx: Enable this driver for Zynq

Hi Michal,

> Enable this driver for Zynq.
> Move it to architecture independent Kconfig part.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
> Build tested by zero day testing system.
> ---
>  drivers/watchdog/Kconfig | 22 +++++++++-------------
>  1 file changed, 9 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9db5d3c..6120403 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -111,6 +111,15 @@ config WM8350_WATCHDOG
>  	  Support for the watchdog in the WM8350 AudioPlus PMIC.  When
>  	  the watchdog triggers the system will be reset.
> 
> +config XILINX_WATCHDOG
> +	tristate "Xilinx Watchdog timer"
> +	select WATCHDOG_CORE
> +	help
> +	  Watchdog driver for the xps_timebase_wdt ip core.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called of_xilinx_wdt.
> +
>  # ALPHA Architecture
> 
>  # ARM Architecture
> @@ -1022,19 +1031,6 @@ config M54xx_WATCHDOG
> 
>  # MicroBlaze Architecture
> 
> -config XILINX_WATCHDOG
> -	tristate "Xilinx Watchdog timer"
> -	depends on MICROBLAZE
> -	select WATCHDOG_CORE
> -	---help---
> -	  Watchdog driver for the xps_timebase_wdt ip core.
> -
> -	  IMPORTANT: The xps_timebase_wdt parent must have the property
> -	  "clock-frequency" at device tree.
> -
> -	  To compile this driver as a module, choose M here: the
> -	  module will be called of_xilinx_wdt.
> -
>  # MIPS Architecture
> 
>  config ATH79_WDT
> --
> 1.8.2.3
> 

Are we sure that we don't need an additional dependancy (like depends on HAS_IOMEM) to not have issues with other architectures?

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/