lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 24 Feb 2014 04:18:40 +0100
From:	Mike Galbraith <mgalbraith@...e.de>
To:	Lei Wen <adrian.wenl@...il.com>
Cc:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	peterz@...radead.org, leiwen@...vell.com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched, nohz: Exclude isolated cores from load
 balancing

On Mon, 2014-02-24 at 10:11 +0800, Lei Wen wrote:

> How about use the API as cpumask_test_and_clear_cpu?
> Then below one line is enough.

Yeah.

> +               if (likely(cpumask_test_and_clear_cpu(cpu,
> nohz.idle_cpus_mask))) {
> 
> And I am not pretty sure whether we need such test here.

It was born because I watched me wreck nohz.nr_cpus :)

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ