linux-kernel - Re: [PATCH 5/8] security: selinux: Use a more current logging style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Feb 2014 12:20:34 -0800
From:	Joe Perches <joe@...ches.com>
To:	Paul Moore <paul@...l-moore.com>
Cc:	linux-kernel@...r.kernel.org, Stephen Smalley <sds@...ho.nsa.gov>,
	Eric Paris <eparis@...isplace.org>,
	James Morris <james.l.morris@...cle.com>,
	selinux@...ho.nsa.gov, linux-security-module@...r.kernel.org
Subject: Re: [PATCH 5/8] security: selinux: Use a more current logging style

On Tue, 2014-02-25 at 15:05 -0500, Paul Moore wrote:
> On Monday, February 24, 2014 01:59:58 PM Joe Perches wrote:
> > Convert printk to pr_<level>.
> > Add pr_fmt.
> > Coalesce formats, add missing space where appropriate.
> > Standardize on one space after "SELinux: " prefix.
> > 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> 
> A few minor comments inline ...
> 
> > diff --git a/security/selinux/avc.c b/security/selinux/avc.c
[]
> > @@ -13,6 +13,9 @@
> >   *	it under the terms of the GNU General Public License version 2,
> >   *	as published by the Free Software Foundation.
> >   */
> > +
> > +#define pr_fmt(fmt) "SELinux: " KBUILD_MODNAME ": " fmt
> > +
> 
> Wouldn't this result in "SELinux: selinux: ..."?  If not great, if so, let's 
> just specify "avc" the old fashioned way.

Yup, you're right.  Thanks.  I stuffed that one up.

$ strings security/selinux/avc.o | grep "^[0-6]"
4SELinux: selinux: seqno %d < latest_notif %d

I'll send a v2.

> > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
[]
> > @@ -5976,9 +5958,9 @@ static __init int selinux_init(void)
> >  		panic("SELinux: Unable to register with kernel.\n");
> > 
> >  	if (selinux_enforcing)
> > -		printk(KERN_DEBUG "SELinux:  Starting in enforcing mode\n");
> > +		printk(KERN_DEBUG "SELinux: Starting in enforcing mode\n");
> >  	else
> > -		printk(KERN_DEBUG "SELinux:  Starting in permissive mode\n");
> > +		printk(KERN_DEBUG "SELinux: Starting in permissive mode\n");

These printks should/will be converted to pr_debug in a
separate patch.  I didn't want to mix these conversions
with the other pr_<level> ones.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/