linux-kernel - Re: [PATCH 06/22] Add helper functions used by arm/arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Mar 2014 14:08:11 +0000
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Roy Franz <roy.franz@...aro.org>
Cc:	Leif Lindholm <leif.lindholm@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	Patch Tracking <patches@...aro.org>
Subject: Re: [PATCH 06/22] Add helper functions used by arm/arm64

On Fri, 14 Feb, at 11:02:49AM, Roy Franz wrote:
> 
> The get_dram_base() function is only used by arm/arm64, but
> there is nothing architecture specific about it, which is why I put it
> here to begin with.  I don't feel strongly about this either way.

Sorry Roy, I just realised that you probably wanted a response from me
about this last point.

OK, leaving get_dram_base() in efi-stub-helper.c is fine.

FYI, "NUL" isn't a typo,

> -	options_size++;  /* NUL termination */
[...]
> +	options_size++;  /* NULL termination */

http://en.wikipedia.org/wiki/Null_character

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/