linux-kernel - Re: [PATCH] pstore: reset ftrace_read_cnt at ramoops_pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2014 09:40:02 +0800
From:	Liu ShuoX <shuox.liu@...el.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>,
	Colin Cross <ccross@...roid.com>,
	Anton Vorontsov <anton@...msg.org>,
	yanmin_zhang@...ux.intel.com
Subject: Re: [PATCH] pstore: reset ftrace_read_cnt at ramoops_pstore_open

On Mon  3.Mar'14 at 11:45:59 -0800, Kees Cook wrote:
>On Thu, Feb 27, 2014 at 10:37 PM,  <shuox.liu@...el.com> wrote:
>> From: Liu ShuoX <shuox.liu@...el.com>
>>
>> ftrace_read_cnt need to be reset in open to support mutli times
>> getting the records.
>>
>> Signed-off-by: Liu ShuoX <shuox.liu@...el.com>
>> ---
>>  fs/pstore/ram.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
>> index fa8cef2..a5d0cab 100644
>> --- a/fs/pstore/ram.c
>> +++ b/fs/pstore/ram.c
>> @@ -101,6 +101,7 @@ static int ramoops_pstore_open(struct pstore_info *psi)
>>
>>         cxt->dump_read_cnt = 0;
>>         cxt->console_read_cnt = 0;
>> +       cxt->ftrace_read_cnt = 0;
>>         return 0;
>>  }
>
>I think we need a separate function for "clear" for the
>ramoops_context struct. IIUC, we're missing a similar initialization
>in ramoops_probe, which lacks both console_read_cnt=0 and
>ftrace_read_cnt=0. Then both places could call this?
Hi Kees,
Currently, we have only one static ramoops_context named oops_cxt.
*_read_cnt should be initialized to 0 as default. Need we still add
such function for 'clear'?

>
>-Kees
>
>-- 
>Kees Cook
>Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/