linux-kernel - Re: [PATCH 1/2] i2c: Add driver for Cadence I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2014 09:20:17 -0800
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	Josh Cartwright <joshc@...eaurora.org>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>,
	Russell King <linux@....linux.org.uk>,
	Michal Simek <michal.simek@...inx.com>,
	Wolfram Sang <wsa@...-dreams.de>, <devicetree@...r.kernel.org>,
	Harini Katakam <harinik@...inx.com>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-i2c@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] i2c: Add driver for Cadence I2C controller

Hi Josh,

On Tue, 2014-03-04 at 11:04AM -0600, Josh Cartwright wrote:
> On Fri, Feb 28, 2014 at 07:06:29PM -0800, S?ren Brinkmann wrote:
> > On Fri, 2014-02-28 at 04:00PM -0800, Soren Brinkmann wrote:
> > > Add a driver for the Cadence I2C controller. This controller is for
> > > example found in Xilinx Zynq.
> > > 
> > > Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>
> > > ---
> > >  .../devicetree/bindings/i2c/i2c-cadence.txt        |  21 +
> > >  MAINTAINERS                                        |   1 +
> > >  drivers/i2c/busses/Kconfig                         |   7 +
> > >  drivers/i2c/busses/Makefile                        |   1 +
> > >  drivers/i2c/busses/i2c-cadence.c                   | 901 +++++++++++++++++++++
> > >  5 files changed, 931 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> > >  create mode 100644 drivers/i2c/busses/i2c-cadence.c
> > > 
> > [...]
> > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > > index f5ed03164d86..7806c1654068 100644
> > > --- a/drivers/i2c/busses/Kconfig
> > > +++ b/drivers/i2c/busses/Kconfig
> > > @@ -375,6 +375,13 @@ config I2C_BLACKFIN_TWI_CLK_KHZ
> > >  	help
> > >  	  The unit of the TWI clock is kHz.
> > >  
> > > +config I2C_CADENCE
> > > +	tristate "Cadence I2C Controller"
> > > +	depends on ARCH_ZYNQ
> > This can be reduced to a dependency on COMMON_CLK only, I think.
> 
> Do you really need to depend on COMMON_CLK?  Most of the clk_* API's are
> properly stubbed when !HAVE_CLK.
I do. clk_register_notifier() is only available with COMMON_CLK.
Alternatively those #ifdefs could go into the driver, but that wouldn't
look nice :)

There is v2 on the list already, let's move the discussion there.

	Sören


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/