linux-kernel - Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2014 22:20:32 +0100
From:	Belisko Marek <marek.belisko@...il.com>
To:	Sebastian Reichel <sre@...ian.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

Hi Sebastian,

On Sat, Mar 1, 2014 at 12:22 AM, Sebastian Reichel <sre@...ian.org> wrote:
> Hi Marek,
>
> On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote:
>> Seems I found issue. I have missing property ti,system-uses-second-madc-irq
>> as original twl4030_madc_battery used SW2 but this change doesn't fix completely
>> the problem.
>
> I remember adding this property because you requested it :) Good to
> know, that its really needed.
>
>> What it fixed completely is change:
>> -       req.raw = !(mask == IIO_CHAN_INFO_PROCESSED);
>> +       req.raw = 0;//!(mask == IIO_CHAN_INFO_PROCESSED);
>
> ok, that figures it. Instead of changing the twl4030-madc driver
> you should change the twl4030-madc-battery driver. You currently
> call iio_read_channel_raw(), which gives you raw values. Your
> driver wants processed data from twl4030-madc, so you should use
> iio_read_channel_processed() instead.
Yes this helps but also not completely :(. twl4030_madc_battery using
chanel 1, 10, 12. Channel 1 and 10 have flag IIO_CHAN_INFO_PROCESSED
set but channel 12 not and values from channel 12 are read as raw which is not
what I want. Can I simply add IIO_CHAN_INFO_PROCESSED also to channel 12?
>
> -- Sebastian

BR,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/