linux-kernel - Re: [PATCH 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Mar 2014 00:31:37 -0800 (PST)
From:	Chase Southwood <chase.southwood@...oo.com>
To:	Hartley Sweeten <HartleyS@...ionengravers.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:	"abbotti@....co.uk" <abbotti@....co.uk>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv_apci1564.c

>On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten <HartleyS@...ionengravers.com> wrote:

>>On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
>>
>>This patch for hwdrv_apci1564.c fixes the register map defines for the
>>digital input registers such that they are all the real offsets to each
>>register, rather than a mix of real offsets and adders to those offsets.
>>
>>Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
>>---
>> .../comedi/drivers/addi-data/hwdrv_apci1564.c      | 101 +++++++++------------
>> 1 file changed, 44 insertions(+), 57 deletions(-)>
>
>This one is incomplete and breaks the build.
>
> CC [M]  drivers/staging/comedi/drivers/addi_apci_1564.o
>In file included from drivers/staging/comedi/drivers/addi_apci_1564.c:11:0:
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: In function >'i_APCI1564_ConfigTimerCounterWatchdog':
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:352:4: error: 'APCI1564_TCW_PROG' >undeclared (first use in this function)
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:352:4: note: each undeclared identifier is >reported only once for each function it appears in
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:359:4: error: 'APCI1564_TCW_RELOAD_VALUE' >undeclared (first use in this function)
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: In function >'i_APCI1564_StartStopWriteTimerCounterWatchdog':
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:463:19: error: 'APCI1564_TCW_PROG' >undeclared (first use in this function)
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: In function >'i_APCI1564_ReadTimerCounterWatchdog':
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:526:4: error: >'APCI1564_TCW_SYNC_ENABLEDISABLE' undeclared (first use in this function)
>drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:529:19: error: 'APCI1564_TCW_TRIG_STATUS' >undeclared (first use in this function)
>make[4]: *** [drivers/staging/comedi/drivers/addi_apci_1564.o] Error 1
>make[3]: *** [drivers/staging/comedi/drivers] Error 2
>make[2]: *** [drivers/staging/comedi] Error 2
>make[1]: *** [drivers/staging] Error 2
>make: *** [drivers] Error 2
>
>Be sure to do a build after each patch to make sure it works.

Hartley,
I'm sorry for this, it appears that this whole patch series was sloppy
and quite untested by myself.  I have made up a fixed patchset and have
tested everything this time around, I trust that you should have a better
time reviewing this one.  I will not let this happen again in the future.

Thanks,
Chase

>
>Regards,
>Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/