linux-kernel - Re: [PATCH 1/7] x86: mm: clean up tlb flushing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Mar 2014 16:51:28 -0800
From:	Davidlohr Bueso <davidlohr@...com>
To:	Dave Hansen <dave@...1.net>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	ak@...ux.intel.com, kirill.shutemov@...ux.intel.com,
	mgorman@...e.de, alex.shi@...aro.org, x86@...nel.org,
	linux-mm@...ck.org, dave.hansen@...ux.intel.com
Subject: Re: [PATCH 1/7] x86: mm: clean up tlb flushing code

On Thu, 2014-03-06 at 16:16 -0800, Davidlohr Bueso wrote:
> On Wed, 2014-03-05 at 16:45 -0800, Dave Hansen wrote:
> > From: Dave Hansen <dave.hansen@...ux.intel.com>
> > 
> > The
> > 
> > 	if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids)
> > 
> > line of code is not exactly the easiest to audit, especially when
> > it ends up at two different indentation levels.  This eliminates
> > one of the the copy-n-paste versions.  It also gives us a unified
> > exit point for each path through this function.  We need this in
> > a minute for our tracepoint.
> > 
> > 
> > Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> > ---
> > 
> >  b/arch/x86/mm/tlb.c |   23 +++++++++++------------
> >  1 file changed, 11 insertions(+), 12 deletions(-)
> > 
> > diff -puN arch/x86/mm/tlb.c~simplify-tlb-code arch/x86/mm/tlb.c
> > --- a/arch/x86/mm/tlb.c~simplify-tlb-code	2014-03-05 16:10:09.607047728 -0800
> > +++ b/arch/x86/mm/tlb.c	2014-03-05 16:10:09.610047866 -0800
> > @@ -161,23 +161,24 @@ void flush_tlb_current_task(void)
> >  void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
> >  				unsigned long end, unsigned long vmflag)
> >  {
> > +	int need_flush_others_all = 1;
> 
> nit: this can be bool.

never mind, you get rid of it later.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/