linux-kernel - Re: [PATCH] lib: remove FBCON dependency for fonts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Mar 2014 11:47:04 +0100
From:	David Herrmann <dh.herrmann@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] lib: remove FBCON dependency for fonts

Hi

On Fri, Mar 7, 2014 at 11:39 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Fri, Mar 7, 2014 at 11:14 AM, David Herrmann <dh.herrmann@...il.com> wrote:
>> Fonts don't depend on CONFIG_FRAMEBUFFER_CONSOLE at all. Remove that.
>> Besides, CONFIG_FONT_SUPPORT is 'select'ed anyway, so the dependencies
>> aren't checked by most higher-level options.
>
> CONFIG_FONT_SUPPORT is indeed selected, but the other options are about
> which fonts to include by default. No dependencies are bypassed by the select.

Indeed, I missed that, sorry.

> Without the "depends on FRAMEBUFFER_CONSOLE", people who don't
> have FRAMEBUFFER_CONSOLE set, but have set any of these:
>
> config EARLY_PRINTK_EFI
>     select FONT_SUPPORT
>
> config VIDEO_VIVI
>     select FONT_SUPPORT
>     select FONT_8x16
>
> config SOLO6X10
>     select FONT_SUPPORT
>     select FONT_8x16
>
> config USB_SISUSBVGA
>     select FONT_SUPPORT
>     ...
>     select FONT_8x16
>
> config SGI_NEWPORT_CONSOLE
>     select FONT_SUPPORT
>
> config STI_CONSOLE
>     select FONT_SUPPORT
>
> will now get more (unused) fonts in their kernel image.

Why would they get more unused fonts? All those fonts are "default n"
(except for some arch-specific stuff and 8x8 and obviously 8x16). I
don't mind if we drop this, but it makes font-selection impossible if
fbcon is disabled, which is kinda unexpected.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/