linux-kernel - Re: [PATCH 00/10] pinctrl: mvebu: remove hard-coded addresses from Dove pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Mar 2014 21:16:33 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Mark Rutland <mark.rutland@....com>, Andrew Lunn <andrew@...n.ch>,
	Russell King <linux@....linux.org.uk>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Rob Landley <rob@...dley.net>,
	Kumar Gala <galak@...eaurora.org>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH 00/10] pinctrl: mvebu: remove hard-coded addresses from
 Dove pinctrl

On Fri, Mar 07, 2014 at 09:26:48AM +0800, Linus Walleij wrote:
> On Wed, Feb 26, 2014 at 10:53 PM, Jason Cooper <jason@...edaemon.net> wrote:
> > On Wed, Feb 26, 2014 at 10:43:45AM +0100, Linus Walleij wrote:
> 
> >> Actually, I'd prefer to pull it in, rebase and sign off each patch
> >> individually in my tree if that is not causing you problems.
> >
> > Actually, that would mess us up pretty badly. :(
> 
> OK so I didn't do this, I just pulled it in :-)

I could tell, Stephen would have had a heart attack :)

> >> That way it is visible that the patches were funneled through pin
> >> control.
> >
> > I'm a little confused by this.  Once you merge the branch into one of
> > yours, that merge commit is a part of the history.
> 
> Yes this has been discussed in the past.

Would you have a link handy?  My first thought was to create a tag, eg
"Sent-through: subsystem <maintainer@...mple.com>" that I would add to
patches as I pull them in.  After all, I know where I'm sending them.
Or should at any rate.

> But when a developer bisects down to a certain commit and just looks
> at it with git log there is no telling which subsystem this thing came
> from and who actually funnelled it to Torvalds.

True.

> I do know you *can* find that out with some git magic, the problem
> is that it is so magic that most developers don't know it and just
> look at the signoffs.

It would be helpful if there were a complement to 'git merge-base', say
'git merge-tip' to point to the merge commit that joined the branch
containing commit X.

Run in succession, it would yield committers me (I merged pinctrl-dove
into pinctrl), you, Torvalds.

> But it's not like I care super-much.

Well, if the code is perfect, we don't have to worry about a lazy
developer bisecting down to one of our commits. ;-)

btw - I have one last pull request I'll be sending tomorrow that's a
couple of commits on top of what you currently have.  It's very small,
but we're avoiding locking ourselves into supporting a bad DT ABI.  The
real code change just downgrades a WARN().  The rest is correcting the
binding doc.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/