lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Mar 2014 17:07:45 -0800 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Kees Cook <keescook@...omium.org>, Evgeniy Polyakov <zbr@...emap.net>, Matt Helsley <matthltc@...ibm.com>, "David S. Miller" <davem@...emloft.net>, Ben Hutchings <ben@...adent.org.uk>, Qiang Huang <h.huangqiang@...wei.com> Subject: [PATCH 3.4 49/99] proc connector: reject unprivileged listener bumps 3.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kees Cook <keescook@...omium.org> commit e70ab977991964a5a7ad1182799451d067e62669 upstream. While PROC_CN_MCAST_LISTEN/IGNORE is entirely advisory, it was possible for an unprivileged user to turn off notifications for all listeners by sending PROC_CN_MCAST_IGNORE. Instead, require the same privileges as required for a multicast bind. Signed-off-by: Kees Cook <keescook@...omium.org> Cc: Evgeniy Polyakov <zbr@...emap.net> Cc: Matt Helsley <matthltc@...ibm.com> Acked-by: Evgeniy Polyakov <zbr@...emap.net> Acked-by: Matt Helsley <matthltc@...ibm.com> Signed-off-by: David S. Miller <davem@...emloft.net> [bwh: Backported to 3.2: adjust context] Signed-off-by: Ben Hutchings <ben@...adent.org.uk> Cc: Qiang Huang <h.huangqiang@...wei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/connector/cn_proc.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/drivers/connector/cn_proc.c +++ b/drivers/connector/cn_proc.c @@ -331,6 +331,12 @@ static void cn_proc_mcast_ctl(struct cn_ if (msg->len != sizeof(*mc_op)) return; + /* Can only change if privileged. */ + if (!capable(CAP_NET_ADMIN)) { + err = EPERM; + goto out; + } + mc_op = (enum proc_cn_mcast_op*)msg->data; switch (*mc_op) { case PROC_CN_MCAST_LISTEN: @@ -343,6 +349,8 @@ static void cn_proc_mcast_ctl(struct cn_ err = EINVAL; break; } + +out: cn_proc_ack(err, msg->seq, msg->ack); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists