| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Mar 2014 22:52:41 -0500 From: Benjamin Tissoires <benjamin.tissoires@...hat.com> To: Benjamin Tissoires <benjamin.tissoires@...il.com>, Jiri Kosina <jkosina@...e.cz>, David Herrmann <dh.herrmann@...il.com>, David Barksdale <dbarksdale@...ogix.com>, Antonio Ospite <ao2@....it>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH v3 2/4] HID: cp2112: remove the last hid_output_raw_report() call tests have shown that output reports use hid_hw_output_report(). Reviewed-by: David Herrmann <dh.herrmann@...il.com> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com> --- changes in v3: - no changes changes in v2: - removed FIXME - actually use the proper calls and do not guess drivers/hid/hid-cp2112.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 3913eb9..56be85a 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -290,7 +290,12 @@ static int cp2112_hid_output(struct hid_device *hdev, u8 *data, size_t count, if (!buf) return -ENOMEM; - ret = hdev->hid_output_raw_report(hdev, buf, count, report_type); + if (report_type == HID_OUTPUT_REPORT) + ret = hid_hw_output_report(hdev, buf, count); + else + ret = hid_hw_raw_request(hdev, buf[0], buf, count, report_type, + HID_REQ_SET_REPORT); + kfree(buf); return ret; } -- 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists