linux-kernel - Re: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Mar 2014 19:19:51 -0700 (PDT)
From:	Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	Morimoto <kuninori.morimoto.gx@...esas.com>,
	Linux-SH <linux-sh@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	dmaengine@...r.kernel.org
Subject: Re: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver


Hi Joe

> > diff --git a/drivers/dma/sh/rcar-audmapp.c b/drivers/dma/sh/rcar-audmapp.c
> []
> > +static int audmapp_chan_probe(struct platform_device *pdev,
> > +			      struct audmapp_device *audev, int id)
> > +{
> []
> > +	auchan = devm_kzalloc(dev, sizeof(struct audmapp_chan), GFP_KERNEL);
> > +	if (!auchan) {
> > +		dev_err(dev, "No free memory for allocating dma channels!\n");
> 
> Unnecessary OOM as the alloc has a generic OOM
> and a dump_stack()
> 
> []
> > +static int audmapp_probe(struct platform_device *pdev)
> > +{
> []
> > +	audev = devm_kzalloc(&pdev->dev, sizeof(struct audmapp_device),
> > +			     GFP_KERNEL);
> > +	if (!audev) {
> > +		dev_err(&pdev->dev, "Not enough memory\n");
> 
> here too

Thank you.
will fix in v3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/