linux-kernel - Re: [PATCH] cpufreq: Reformat printk() statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Mar 2014 11:53:53 +0800
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Soren Brinkmann <soren.brinkmann@...inx.com>
Cc:	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: Reformat printk() statement

On 7 March 2014 01:34, Soren Brinkmann <soren.brinkmann@...inx.com> wrote:
> Reformat a printk statement to:
>  - use pr_warn
>  - bring the whole string into a single line in favor of being able to
>    grep for the message (ignoring the 80 char limit)
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>
> ---
>  drivers/cpufreq/cpufreq.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index cb003a6b72c8..534c2df608ed 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1874,11 +1874,8 @@ static int __cpufreq_governor(struct cpufreq_policy *policy,
>                 if (!gov)
>                         return -EINVAL;
>                 else {
> -                       printk(KERN_WARNING "%s governor failed, too long"
> -                              " transition latency of HW, fallback"
> -                              " to %s governor\n",
> -                              policy->governor->name,
> -                              gov->name);
> +                       pr_warn("%s governor failed, too long transition latency of HW, fallback to %s governor\n",
> +                                       policy->governor->name, gov->name);
>                         policy->governor = gov;
>                 }
>         }

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/