linux-kernel - Linking reviews and commits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 11 Mar 2014 00:06:33 -0400
From:	Murtuza Mukadam <murtuza.i.mukadam@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Peter Rigby <rigbypc@...il.com>, gregkh@...uxfoundation.org,
	Takashi Iwai <tiwai@...e.de>
Subject: Linking reviews and commits

Hi,

We have linked commits with their respective peer review discussion on LKML.
You can search for reviews of commits here:

http://cesel.encs.concordia.ca/process_request.php?repo=linux

We also created a tool that allows you to load and view reviews within
git (the tool is beta):

http://users.encs.concordia.ca/~m_mukada/git-review-tutorial.html

This work is done as part of my thesis.

Cheers,
Murtuza


Feedback from Greg KH and Takashi Iwai:

Greg KH found the idea of the tool useless saying, "That's what google
is for :)"

On Fri, Jan 31, 2014 at 2:03 PM, Takashi Iwai <tiwai@...e.de> wrote:
> sorry for my late response, as I've been really too busy to play with
> your shiny scripts.  Now finally I could find minutes to try out.
> Here are some comments after a short try:
> - It's nice command line things that are aligned well with the
>   existing git tools.

Thanks we tried to mirror the git commands.

> - Direct view with github isn't too bad, but a better GUI would be
>   definitely helpful, so that you can surf reviews more easily by
>   pointing a commit id.

You can search for reviews of commits here:

http://cesel.encs.concordia.ca/process_request.php?repo=linux

> - Can this work like git-notes?  That is, showing reviews via git log
>   with an option?

There is another tool that was discussed on the git mailing list that
works with git-notes:

http://repo.or.cz/w/trackgit.git

> - The installation could be a bit improved.  It's easy, but the
>   provided script works only for Debian & co.

Yes, you are right, for now the other distributions require getting
the right libraries. Is there a distribution you'd like to see in
particular?

> - A command git-review already exists (for Gerrit), so this name might
>   be confusing for some people.

Yes I we've changed the name to git-reviewed

> - I couldn't see any information, though, about how to gather the
>   reviews and put into the repo.  Is it a part of project?
>   Majority of patches are floating rather in each subsystem ML, not in
>   LKML, so each tree may need a different setup.

If you have a particular mailing list you would like us to import, we
will do it for you. If you wish to do it yourself, we have a command
git update-review

(http://users.encs.concordia.ca/~m_mukada/git-review-tutorial.html#OtherFeatures)

which will allow you to link reviews from an mbox file.
Note: since each linked email review is stored within git,
if there are a large number of reviews, it can bloat the size of your repo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/