linux-kernel - Re: [PATCH 3/3] x86, vdso32: handle 32 bit vDSO larger one page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 13 Mar 2014 12:33:49 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andy Lutomirski <luto@...capital.net>
CC:	Pavel Emelyanov <xemul@...allels.com>,
	Ingo Molnar <mingo@...hat.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stefani Seibold <stefani@...bold.net>,
	Greg KH <gregkh@...uxfoundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Andreas Brief <Andreas.Brief@...de-schwarz.com>,
	Andi Kleen <ak@...ux.intel.com>,
	John Stultz <john.stultz@...aro.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Martin Runge <Martin.Runge@...de-schwarz.com>,
	the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH 3/3] x86, vdso32: handle 32 bit vDSO larger one page

If we have to stick anything in the fixmap it might add well be the real vdso...

On March 13, 2014 12:21:54 PM PDT, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>On Mar 13, 2014 12:13 PM, "Andy Lutomirski" <luto@...capital.net>
>wrote:
>>
>> How?  We either set null in AT_SYSINFO_EHDR, we set something simple
>> that SuSE is okay with (and compile separate images?) or we set
>> something fancy and not relocated, and SuSE crashes.
>
>Yeah, I was thinking that "something simple is the fixmap space that
>suse
>would be happy with"
>
>Keyword being "simple", ie so simple that it's not a maintenance
>headache
>even if it's different from the "real" vdso.
>
>But I suspect we don't really need it.
>
>> On a related note: is it okay to keep the option called
>> CONFIG_COMPAT_VDSO but change the default to n?
>
>Yes. If you start from scratch with a config, you have to get the
>options
>right. It's just the "I upgraded the kernel, did an oldconfig, and it
>doesn't work" case that we should avoid.
>
>The alternative would be to make a new config name, but then it has to
>default to the compatible state (iow no vdso at all by default),
>because
>that's the rule: make oldconfig should work for people.
>
>Basically, kernel upgrades should be nobrainers and "just work".
>
>     Linus

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/