linux-kernel - Re: [PATCH] drivers: rtc: rtc-s3c: remove NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Mar 2014 10:21:49 +0900
From:	Pankaj Dubey <pankaj.dubey@...sung.com>
To:	Pankaj Dubey <pankaj.dubey@...sung.com>
Cc:	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	a.zummo@...ertech.it
Subject: Re: [PATCH] drivers: rtc: rtc-s3c: remove NO_IRQ macro

On 03/05/2014 08:12 PM, Pankaj Dubey wrote:
> NO_IRQ may be defined as '(unsigned int) -1' in some architectures
> (arm, sh ...), and either may not be defined in some architectures
> (arm64) which can enable RTC_DRV_S3C.
> Also since platform_get_irq returns err-code in case of any error,
> we do not need to intialize s3c_rtc_alarmno and s3c_rtc_tickno.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com>
> ---
>   drivers/rtc/rtc-s3c.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index 7afd373..cf2ebdd 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -48,8 +48,8 @@ struct s3c_rtc_drv_data {
>   
>   static struct clk *rtc_clk;
>   static void __iomem *s3c_rtc_base;
> -static int s3c_rtc_alarmno = NO_IRQ;
> -static int s3c_rtc_tickno  = NO_IRQ;
> +static int s3c_rtc_alarmno;
> +static int s3c_rtc_tickno;
>   static enum s3c_cpu_type s3c_rtc_cpu_type;
>   
>   static DEFINE_SPINLOCK(s3c_rtc_pie_lock);

Gentle Ping.

-- 
Best Regards,
Pankaj Dubey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/