linux-kernel - Re: [PATCH] Revert "Bluetooth: Use devname:vhci module alias for virtual HCI driver"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKi4VA+W7BfhGDUTT0tgroO-YPAztAXy-K-b3jiC3BiNwwba8Q@mail.gmail.com>
Date:	Tue, 18 Mar 2014 08:34:33 -0300
From:	Lucas De Marchi <lucas.de.marchi@...il.com>
To:	Thomas Bächler <thomas@...hlinux.org>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	Josh Boyer <jwboyer@...oraproject.org>,
	"Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	linux-bluetooth@...r.kernel.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "Bluetooth: Use devname:vhci module alias for
 virtual HCI driver"

Hi Thomas

On Wed, Mar 5, 2014 at 3:48 PM, Thomas Bächler <thomas@...hlinux.org> wrote:
> Am 05.03.2014 19:36, schrieb Marcel Holtmann:
>>>>> This reverts commit bfacbb9aec029b3200053d84c8cd5d7575f2d4a5.
>>>>
>>>> NAK. We allocated a static minor for this.
>>>
>>> Johan mentioned that.  Commit b075dd40c95d11c2c8690f6c4d6232fc,
>>> correct?
>
> I am sorry Marcel, I only looked at the Linus tree, not at bluetooth or
> bluetooth-next. This commit should indeed fix the problem. Disregard my
> patch.
>
>>  Why isn't that headed into 3.14 right now, and CC'd to
>>> stable?  Currently you have a somewhat broken driver in 3.13 and
>>> 3.14-rcX that seems to have a pretty clear fix.
>>
>> somewhat broken? kmod prints this as an error, but it is not a regression in user functionality. The driver works just as before. The error message can be ignored.
>
> It's a regression in my sanity, since numerous users blame all kernel
> bugs on this error message and I am tired of explaining the situation
> (problem + error message == problem found *sigh*). I only sent this
> patch since I hadn't found the correct fix.

Feel free to CC kmod mailing list in these cases
(linux-modules@...r.kernel.org). We've added this message to kmod
exactly to catch problems like this and help people doing the drivers.
Once I found out the problem with vhci I sent the patch to fix it,
which is heading to Linus tree.

-- 
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/