linux-kernel - [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Mar 2014 00:33:19 +0200
From:	Matei Oprea <eu@...eamatei.ro>
To:	gregkh@...uxfoundation.org
Cc:	sachin.kamat@...aro.org, shaun@...source.ca,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Matei Oprea <eu@...eamatei.ro>,
	ROSEdu Kernel Community <firefly@...ts.rosedu.org>
Subject: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

This fixes the following sparse warning:
* drivers/staging/cxt1e1/hwprobe.c:43:19: 
warning: symbol 'hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:47:1: 
warning: symbol 'show_two' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:99:1: 
warning: symbol 'hdw_sn_get' was not declared. Should it be static?
*drivers/staging/cxt1e1/hwprobe.c:149:1: 
warning: symbol 'prep_hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:169:1: 
warning: symbol 'cleanup_ioremap' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:195:1: 
warning: symbol 'cleanup_devs' was not declared. Should it be static?
drivers/staging/cxt1e1/hwprobe.c:293:1: 
* warning: symbol 'c4hw_attach_all' was not declared. Should it be static?

Signed-off-by: Matei Oprea <eu@...eamatei.ro>
Cc: ROSEdu Kernel Community <firefly@...ts.rosedu.org>
---
 drivers/staging/cxt1e1/hwprobe.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 02b4f8f..694047a 100644
--- a/drivers/staging/cxt1e1/hwprobe.c
+++ b/drivers/staging/cxt1e1/hwprobe.c
@@ -40,10 +40,10 @@ void        c4_stopwd (ci_t *);
 struct net_device * __init c4_add_dev (hdw_info_t *, int, unsigned long, unsigned long, int, int);
 
 
-struct s_hdw_info hdw_info[MAX_BOARDS];
+static struct s_hdw_info hdw_info[MAX_BOARDS];
 
 
-void        __init
+static void        __init
 show_two (hdw_info_t *hi, int brdno)
 {
     ci_t       *ci;
@@ -95,7 +95,7 @@ show_two (hdw_info_t *hi, int brdno)
 }
 
 
-void        __init
+static void        __init
 hdw_sn_get (hdw_info_t *hi, int brdno)
 {
     /* obtain hardware EEPROM information */
@@ -145,7 +145,7 @@ hdw_sn_get (hdw_info_t *hi, int brdno)
 }
 
 
-void        __init
+static void        __init
 prep_hdw_info (void)
 {
     hdw_info_t *hi;
@@ -165,7 +165,7 @@ prep_hdw_info (void)
     }
 }
 
-void
+static void
 cleanup_ioremap (void)
 {
     hdw_info_t *hi;
@@ -191,7 +191,7 @@ cleanup_ioremap (void)
 }
 
 
-void
+static void
 cleanup_devs (void)
 {
     hdw_info_t *hi;
@@ -289,7 +289,7 @@ c4_hdw_init (struct pci_dev *pdev, int found)
 }
 
 
-status_t    __init
+static status_t    __init
 c4hw_attach_all (void)
 {
     hdw_info_t *hi;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/