lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Mar 2014 07:52:19 +0100 From: Stanislaw Gruszka <sgruszka@...hat.com> To: David Vrabel <david.vrabel@...rix.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, xen-devel@...ts.xenproject.org, kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org, linux-kernel@...r.kernel.org Subject: Re: [Xen-devel] [PATCH] xen: declare notifier_block on xen-ops.h On Mon, Mar 17, 2014 at 05:56:03PM +0000, David Vrabel wrote: > On 17/03/14 07:48, Stanislaw Gruszka wrote: > > Patch fixes below warnings: > > > > In file included from arch/x86/xen/xen-ops.h:7:0, > > from arch/x86/xen/vga.c:9: > >>> include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default] > > void xen_resume_notifier_register(struct notifier_block *nb); > > ^ > >>> include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > >>> include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default] > > void xen_resume_notifier_unregister(struct notifier_block *nb); > > Is this a fix up to your previous "xen/acpi-processor: fix enabling > interrupts on syscore_resume" patch? Yes. > If so, do you mind if we squash > the two commits together? So bisectability is improved. No problem with that (though I don't think actual build is broken since we don't use xen_resume_notifier_register on .c files that do not include linux/notifier.h directly or indirectly). Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists