| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Mar 2014 09:14:04 +0000 From: Lee Jones <lee.jones@...aro.org> To: Krzysztof Kozlowski <k.kozlowski@...sung.com> Cc: Sachin Kamat <sachin.kamat@...aro.org>, broonie@...nel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01 > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > rtc-s5m driver does not support S2MPA01. > > This fixes following error: > drivers/mfd/sec-core.c:342:45: warning: ‘regmap_rtc’ may be used uninitialized in this function [-Wuninitialized] > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> > --- > drivers/mfd/sec-core.c | 7 +++++++ > 1 file changed, 7 insertions(+) Please don't send patches in the middle of threads like this (v2's are a different story as it saves on re-sending entire patch-sets), as I very nearly missed it. We already have drivers doing similar things so I'll apply this as a temporary fix, but please find something a little less 'hacky' to supersede it _soon_. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists