| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Mar 2014 21:35:13 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Ben Hutchings <ben@...adent.org.uk> Cc: Patrick Lai <plai@...eaurora.org>, Mark Brown <broonie@...aro.org>, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH 3.13 110/149] ASoC: pcm: free path list before exiting from error conditions On Sat, Mar 22, 2014 at 03:53:08PM +0000, Ben Hutchings wrote: > On Thu, 2014-03-20 at 17:04 -0700, Greg Kroah-Hartman wrote: > > 3.13-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Patrick Lai <plai@...eaurora.org> > > > > commit e4ad1accb28d0ed8cea6f12395d58686ad344ca7 upstream. > > > > dpcm_path_get() allocates dynamic memory to hold path list. > > Corresponding dpcm_path_put() must be called to free the memory. > > dpcm_path_put() is not called under several error conditions. > > This leads to memory leak. > > This is broken. dpcm_path_get() may return -ENOMEM and not initialise > the list at all. > > If snd_soc_dapm_dai_get_connected_widgets() can fail (I don't think it > can) then dpcm_path_get() should be responsible for freeing the list > before returning. Thanks, now dropped. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists