| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Mar 2014 18:36:18 +0000 From: Wilfried Klaebe <w-lkml@...enslange-mailadresse.de> To: Greg KH <gregkh@...uxfoundation.org> Cc: Larry.Finger@...inger.net, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH: > On Tue, Mar 25, 2014 at 05:59:39PM +0000, Wilfried Klaebe wrote: > > staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls > > > > It looks like someone did a search-and-replace on that driver, putting > > spaces before "=" characters, without checking this is OK everywhere. > > Also, in some places, there's memcpm()s/strncmp()s checking for some > > different length than the fixed string argument. > > > > These things result in code not working as intended. Fix that. > > What code is parsing string output from the kernel? I know about some userspace apps, for example a MiraCast Sink implementation for the Raspberry Pi, called piracast. This patch though is about the rtl8188eu driver parsing strings handed to it via "iwpriv wlanX p2p_set name=value". Which breaks, because the driver checks for "name =" instead of "name=" in several cases. Regards, Wilfried -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists