linux-kernel - Re: [PATCH] bonding: Inactive slaves should keep inactive flag's value to 1 in tlb and alb mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Mar 2014 08:53:14 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	"zheng.li" <zheng.x.li@...cle.com>
CC:	<netdev@...r.kernel.org>, <fubar@...ibm.com>, <andy@...yhouse.net>,
	<linux-kernel@...r.kernel.org>, <davem@...emloft.net>,
	<joe.jin@...cle.com>
Subject: Re: [PATCH] bonding: Inactive slaves should keep inactive flag's
 value to 1 in tlb and alb mode.

On 2014/3/25 16:36, zheng.li wrote:
> 于 2014年03月25日 11:42, Ding Tianhong 写道:
>> On 2014/3/25 11:00, Zheng Li wrote:
>>> In bond mode tlb and alb, inactive slaves should keep inactive flag to
>>> 1 to refuse to receive broadcast packets. Now, active slave send broadcast packets
>>> (for example ARP requests) which will arrive inactive slaves on same host from switch,
>>> but inactive slave's inactive flag is zero that cause bridge receive the broadcast
>>> packets to produce a wrong entry in forward table. Typical situation is domu send some
>>> ARP request which go out from dom0 bond's active slave, then the ARP broadcast request
>>> packets go back to inactive slave from switch, because the inactive slave's inactive
>>> flag is zero, kernel will receive the packets and pass them to bridge, that cause dom0's
>>> bridge map domu's MAC address to port of bond, bridge should map domu's MAC to port of vif.
>>>
>>> Signed-off-by: Zheng Li <zheng.x.li@...cle.com>
>>> ---
>>>  drivers/net/bonding/bond_main.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>>> index e5628fc..8761df6 100644
>>> --- a/drivers/net/bonding/bond_main.c
>>> +++ b/drivers/net/bonding/bond_main.c
>>> @@ -3062,7 +3062,7 @@ static int bond_open(struct net_device *bond_dev)
>>>  				&& (slave != bond->curr_active_slave)) {
>>>  				bond_set_slave_inactive_flags(slave,
>>>  							      BOND_SLAVE_NOTIFY_NOW);
>>> -			} else {
>>> +			} else if (!bond_is_lb(bond)) {
>>>  				bond_set_slave_active_flags(slave,
>>>  							    BOND_SLAVE_NOTIFY_NOW);
>>>  			}
>>>
>> I think you did not fix the problem completely, the state monitor will change the status for the slaves
>> and the inactive slave still could receive the broadcast.
> 
> Had tested, it can fix the issue, verified by our QA.
> Default set slave of bond as inactive when add a slave to bond, when
> link UP, just set one slave as current active slave and clear its
> inactive flag, the inactive slave's inactive flag will keep the value of 1.
> 
> 
Ok, I found that in the mii monitor, it will only change the backup state, no problem,
it looks good to me.

Ding

>>
>> Regards
>> Ding
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> 
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/