linux-kernel - Re: [PATCH] cdrom.c: Only read a cdrom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Mar 2014 19:48:46 +0000 (UTC)
From:	Reimar Döffinger <Reimar.Doeffinger@....de>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cdrom.c: Only read a cdrom_msf0 struct from userspace.

Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> That is all that is actually used, reading more just
> makes the code confusing.
> In addition also fix the header and separate documentation
> to correctly indicate which struct is expected as input.
> 
> Maybe these inconsistencies were on purpose at some point
> with the intention to improve the IOCTL interface, but
> the code has now been unchanged for years and changing
> it would break e.g. MPlayer which fills the second half
> of the cdrom_msf struck with garbage, so I believe
> that at this point it is best commit to current behaviour
> and make the whole documentation less confusing.

ping
Having one piece of documentation that is clearly utter nonsense and then a
second piece of documentation that adds a note that the first documentation
is wrong sure isn't the way to keep things.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/