lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Mar 2014 19:19:57 +0200 From: Andi Kleen <andi@...stfloor.org> To: Jovi Zhangwei <jovi.zhangwei@...il.com> Cc: Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...hat.com>, Steven Rostedt <rostedt@...dmis.org>, LKML <linux-kernel@...r.kernel.org>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Frederic Weisbecker <fweisbec@...il.com> Subject: Re: [PATCH v2 10/29] ktap: add string handling code(kernel/trace/ktap/kp_[str|mempool].[c|h]) > See test/benchmark/cmp_table.sh, that script compare Is that a realistic tracing scenario? > table operation between ktap with stap, the result is very > inspiring, ktap table operation overhead is quite lower than > stap, especially when use constant string key. Ok fair enough. > > But I agree with you partly, because in some cases we don't > want/need to interning all string, for example: > trace xxx:yyy { > var str = cast("char *", arg1) > print(str) > } > > In above case, arg1 is a long kernel string, and no table insert, > so definitely no need to interned, so we need to add > KTAP_TRAWSTR to represent these values. Please don't make it more complicated. If there's a good rationale for interning it' ok to use always. It would be better to find ways to simplify things. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists