linux-kernel - Re: [v3.2.y][PATCH 1/1] cifs: set MAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 30 Mar 2014 21:34:10 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Joseph Salisbury <joseph.salisbury@...onical.com>
Cc:	sfrench@...ba.org, linux-cifs@...r.kernel.org,
	samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [v3.2.y][PATCH 1/1] cifs: set MAY_SIGN when sec=krb5

On Fri, 2014-02-28 at 16:07 -0500, Joseph Salisbury wrote:
> Backport from mainline commit: 0b7bc84000d71f3647ca33ab1bf5bd928535c846.
> This backport was done so including mainline commit
> 8830d7e07a5e38bc47650a7554b7c1cfd49902bf is not needed.
> 
> BugLink: http://bugs.launchpad.net/bugs/1285723
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@...onical.com>

Queued up for 3.2, thanks.

Please include the original patch header in future.

Ben.

> ---
>  fs/cifs/connect.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 56c152d..49d6e21 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1113,7 +1113,8 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
>  				cERROR(1, "Krb5 cifs privacy not supported");
>  				goto cifs_parse_mount_err;
>  			} else if (strnicmp(value, "krb5", 4) == 0) {
> -				vol->secFlg |= CIFSSEC_MAY_KRB5;
> +				vol->secFlg |= CIFSSEC_MAY_KRB5 | 
> +					CIFSSEC_MAY_SIGN;
>  			} else if (strnicmp(value, "ntlmsspi", 8) == 0) {
>  				vol->secFlg |= CIFSSEC_MAY_NTLMSSP |
>  					CIFSSEC_MUST_SIGN;

-- 
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)