[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 4 Apr 2014 09:57:36 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Rob Herring <robherring2@...il.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Grant Likely <grant.likely@...aro.org>,
Rob Herring <robh@...nel.org>,
Mark Salter <msalter@...hat.com>,
Aurelien Jacquiot <a-jacquiot@...com>,
linux-c6x-dev@...ux-c6x.org
Subject: Re: [PATCH 06/20] c6x: convert fdt pointers to opaque pointers
Hi Rob,
On Fri, Apr 4, 2014 at 12:16 AM, Rob Herring <robherring2@...il.com> wrote:
> --- a/arch/c6x/kernel/setup.c
> +++ b/arch/c6x/kernel/setup.c
> @@ -265,8 +265,8 @@ int __init c6x_add_memory(phys_addr_t start, unsigned long size)
> */
> notrace void __init machine_init(unsigned long dt_ptr)
> {
> - struct boot_param_header *dtb = __va(dt_ptr);
> - struct boot_param_header *fdt = (struct boot_param_header *)_fdt_start;
> + const void *dtb = __va(dt_ptr);
> + const void *fdt = (const void *)_fdt_start;
Unless it has changed recently, _fdt_start is "char _fdt_start[]",
so the cast should not be needed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists