[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 04 Apr 2014 17:18:50 +0800
From: Chen Gang <gang.chen.5i5j@...il.com>
To: tytso@....edu, adilger.kernel@...ger.ca
CC: linux-ext4@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
gxt@...c.pku.edu.cn
Subject: Re: [PATCH] fs/ext4/extents_status.c: fix 64-bit number truncation
bug
Hello Maintains:
Please help check this patch, when you have time, thanks.
On 03/31/2014 09:16 PM, Chen Gang wrote:
> '0x7FDEADBEEF' will be truncated to 32-bit number under unicore32. Need
> append 'ULL' for it.
>
> The related warning (with allmodconfig under unicore32):
>
> CC [M] fs/ext4/extents_status.o
> fs/ext4/extents_status.c: In function ‘__es_remove_extent’:
> fs/ext4/extents_status.c:813: warning: integer constant is too large for ‘long’ type
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
> fs/ext4/extents_status.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index 0a014a7..0ebc212 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -810,7 +810,7 @@ retry:
>
> newes.es_lblk = end + 1;
> newes.es_len = len2;
> - block = 0x7FDEADBEEF;
> + block = 0x7FDEADBEEFULL;
> if (ext4_es_is_written(&orig_es) ||
> ext4_es_is_unwritten(&orig_es))
> block = ext4_es_pblock(&orig_es) +
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists