linux-kernel - Re: [PATCH] usb: ohci-exynos: Remove locks for 'ohci' in suspend callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 4 Apr 2014 19:27:36 +0530
From:	Vivek Gautam <gautamvivek1987@...il.com>
To:	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Manjunath Goudar <csmanjuvijay@...il.com>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH] usb: ohci-exynos: Remove locks for 'ohci' in suspend callback

On Fri, Apr 4, 2014 at 7:03 PM, Vivek Gautam <gautamvivek1987@...il.com> wrote:
> Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend
> has already removed 'ohci_hcd' settings from exynos glue layer
> as a part of streamlining the ohci controller's suspend.
> So we don't need the locks for 'ohci_hcd' anymore.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
> Cc: Manjunath Goudar <csmanjuvijay@...il.com>
> Cc: Alan Stern <stern@...land.harvard.edu>
> ---

Please ignore this patch, WIP, got sent by mistake :-(
Sorry for spamming.

>  drivers/usb/host/ohci-exynos.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
> index 68588d8..7f5e779 100644
> --- a/drivers/usb/host/ohci-exynos.c
> +++ b/drivers/usb/host/ohci-exynos.c
> @@ -199,8 +199,6 @@ static int exynos_ohci_suspend(struct device *dev)
>         if (rc)
>                 return rc;
>
> -       spin_lock_irqsave(&ohci->lock, flags);
> -
>         if (exynos_ohci->otg)
>                 exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self);
>
> @@ -208,8 +206,6 @@ static int exynos_ohci_suspend(struct device *dev)
>
>         clk_disable_unprepare(exynos_ohci->clk);
>
> -       spin_unlock_irqrestore(&ohci->lock, flags);
> -
>         return 0;
>  }
>
> --
> 1.7.10.4
>



-- 
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/