[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 04 Apr 2014 08:28:07 -0700
From: Joe Perches <joe@...ches.com>
To: Kumar Amit Mehta <gmate.amit@...il.com>
Cc: Dan Carpenter <dan.carpenter@...cle.com>, abbotti@....co.uk,
hsweeten@...ionengravers.com, wharms@....de,
gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding
style issue
On Fri, 2014-04-04 at 18:17 +0300, Kumar Amit Mehta wrote:
> What Walter mentioned also makes sense, So shouldn't it be something
> like this:
I'm not Dan, but:
> [amit@...alhost linux-next]$ git diff
> diff --git a/drivers/staging/comedi/drivers/pcl812.c
> b/drivers/staging/comedi/drivers/pcl812.c
> index 160eac8..552b696 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -803,16 +803,14 @@ static int pcl812_ai_cmd(struct comedi_device
> *dev, struct comedi_subdevice *s)
>
> pcl812_ai_set_chan_range(dev, cmd->chanlist[0], 1);
>
> + devpriv->ai_dma = 0;
> if (devpriv->dma) { /* check if we can use DMA transfer */
> devpriv->ai_dma = 1;
> for (i = 1; i < cmd->chanlist_len; i++)
> if (cmd->chanlist[0] != cmd->chanlist[i]) {
> /* we cann't use DMA :-( */
> - devpriv->ai_dma = 0;
No.
You enable unwanted DMA capability here.
There's a typo of can't too.
> break;
> }
> - } else
> - devpriv->ai_dma = 0;
Otherwise, I suppose either style is OK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists