linux-kernel - Re: [PATCH 1/1] staging: comedi: Fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Apr 2014 12:56:15 -0700
From:	Joe Perches <joe@...ches.com>
To:	Camille Begue <camille.begue44@...il.com>
Cc:	devel@...verdev.osuosl.org, Ian Abbott <abbotti@....co.uk>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] staging: comedi: Fix checkpatch warning

On Fri, 2014-04-04 at 21:15 +0200, Camille Begue wrote:
> This patch is part of eudyptula challenge

Hello Camille.

Please do not write commit log messages like this.
Say what's wrong with the code, not why you did it.

Write something like:

Wrap lines > 80 columns.

> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
[]
> @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
>  	s = &dev->subdevices[cmd->subdev];
>  
>  	if (s->type == COMEDI_SUBD_UNUSED) {
> -		dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> +		dev_dbg(dev->class_dev,
> +			"%d not valid subdevice\n",
> +			cmd->subdev);

If you really want to fix > 80 column lines, it'd be
better to keep the dev_dbg and format on the same line

         1         2         3         4         5         6         7         8
12345678901234567890123456789012345678901234567890123456789012345678901234567890
		dev_dbg(dev->class_dev, "%d not valid subdevice\n",
			cmd->subdev);

>  		return -EIO;
>  	}
>  
>  	if (!s->do_cmd || !s->do_cmdtest || !s->async) {
>  		dev_dbg(dev->class_dev,
> -			"subdevice %d does not support commands\n", cmd->subdev);
> +			"subdevice %d does not support commands\n",
> +			cmd->subdev);
>  		return -EIO;
>  	}
>  

here too


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/