linux-kernel - Re: [PATCH] topology: Fix compilation warning when not in SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Apr 2014 16:49:43 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Vincent Stehlé <vincent.stehle@...oste.net>
Cc:	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] topology: Fix compilation warning when not in SMP

On Fri, Apr 04, 2014 at 08:43:18AM +0200, Vincent Stehlé wrote:
> The topology_##name() macro does not use its argument when CONFIG_SMP is not
> set, as it ultimately calls the cpu_data() macro.
> 
> So we avoid maintaining a possibly unused `cpu' variable, to avoid the
> following compilation warning:
> 
>   drivers/base/topology.c: In function ‘show_physical_package_id’:
>   drivers/base/topology.c:103:118: warning: unused variable ‘cpu’ [-Wunused-variable]
>    define_id_show_func(physical_package_id);
> 
>   drivers/base/topology.c: In function ‘show_core_id’:
>   drivers/base/topology.c:106:106: warning: unused variable ‘cpu’ [-Wunused-variable]
>    define_id_show_func(core_id);
> 
> This can be seen with e.g. x86 defconfig and CONFIG_SMP not set.
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: <stable@...r.kernel.org> # 3.10.x
> Cc: <stable@...r.kernel.org> # 3.13.x
> Cc: <stable@...r.kernel.org> # 3.14.x

Warnings aren't a stable kernel issue, so why would this be relevant
there?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/