linux-kernel - Re: [PATCH] ARC: Remove ISS_SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 08 Apr 2014 12:42:23 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARC: Remove ISS_SMP_EXTN entirely

Vineet,

On Tue, 2014-04-08 at 09:18 +0000, Vineet Gupta wrote:
> There's obvious bitrot here - however this code is not dead yet !
> I have a unpushed fix which uses this Kconfig item.
> 
> diff --git a/arch/arc/plat-arcfpga/Makefile b/arch/arc/plat-arcfpga/Makefile
> index a44e22ebc1b7..4d1bddc34b5b 100644
> --- a/arch/arc/plat-arcfpga/Makefile
> +++ b/arch/arc/plat-arcfpga/Makefile
> @@ -9,4 +9,4 @@
>  KBUILD_CFLAGS  += -Iarch/arc/plat-arcfpga/include
>  
>  obj-y := platform.o irq.o
> -obj-$(CONFIG_SMP)              += smp.o
> +obj-$(CONFIG_ISS_SMP_EXTN)             += smp.o

I just realized that this means you're only using ISS_SMP_EXTN as an
alias for SMP, aren't you? Ie, smp.o will now be built if both
ARC_PLAT_FPGA_LEGACY and SMP are set. That will not change by this
patch.

So unless you're planning to do something else too if ISS_SMP_EXTN is
set there seems to be little value in using this symbol like that.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/