linux-kernel - Re: [PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Apr 2014 14:19:29 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jimmy Li <coder.liss@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Teodora Baluta <teobaluta@...il.com>,
	Joe Perches <joe@...ches.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Michael Gunselmann <michael.gunselmann@...dium.uni-erlangen.de>,
	Lisa Nguyen <lisa@...apiadmin.com>,
	Martin Hofmann <martin.hofmann@...dium.uni-erlangen.de>,
	Malcolm Priestley <tvboxspy@...il.com>,
	=?us-ascii?Q?=3D=3Futf-8=3FB=3FVMO8bGluIMSwemVy=3F=3D?= <tulinizer@...il.com>,
	Archana kumari <archanakumari959@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning

On Tue, Apr 08, 2014 at 07:09:27PM +0800, Jimmy Li wrote:
> thanks for correcting my patch format.
> 
> Signed-off-by: Jimmy Li <coder.liss@...il.com>
> ---
> v1 fix a sparse warning.
> 	(iwctl.c:1846:35: expected restricted gfp_t [usertype] flags)
> v2 clear up two unnecessary variable, buf and blen.
> v3 fix patch format.
>  drivers/staging/vt6655/iwctl.c |    9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

Please try applying your patch.  Save the email as raw text including
headers and everything.  `cat raw_email.txt | git am`.  Then review the
log with `git log`.  You'll see that the format is still messed up.  :(

The part which should be discarded is saved and the part which should be
saved is deleted.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/