lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Apr 2014 11:01:01 +0900 From: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com> To: Luiz Capitulino <lcapitulino@...hat.com> CC: <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>, <mtosatti@...hat.com>, <aarcange@...hat.com>, <mgorman@...e.de>, <akpm@...ux-foundation.org>, <andi@...stfloor.org>, <davidlohr@...com>, <rientjes@...gle.com>, <yinghai@...nel.org>, <riel@...hat.com> Subject: Re: [PATCH 2/4] hugetlb: update_and_free_page(): don't clear PG_reserved bit (2014/04/03 3:08), Luiz Capitulino wrote: > Hugepages pages never get the PG_reserved bit set, so don't clear it. But > add a warning just in case. > > Signed-off-by: Luiz Capitulino <lcapitulino@...hat.com> > --- Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com> Thanks, Yasuaki Ishimatsu > mm/hugetlb.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 8c50547..7e07e47 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -581,8 +581,9 @@ static void update_and_free_page(struct hstate *h, struct page *page) > for (i = 0; i < pages_per_huge_page(h); i++) { > page[i].flags &= ~(1 << PG_locked | 1 << PG_error | > 1 << PG_referenced | 1 << PG_dirty | > - 1 << PG_active | 1 << PG_reserved | > - 1 << PG_private | 1 << PG_writeback); > + 1 << PG_active | 1 << PG_private | > + 1 << PG_writeback); > + WARN_ON(PageReserved(&page[i])); > } > VM_BUG_ON_PAGE(hugetlb_cgroup_from_page(page), page); > set_compound_page_dtor(page, NULL); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists