linux-kernel - Re: [PATCH] Staging: bcm: Qos: fixed braces' coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Apr 2014 14:11:03 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Luis Ortega <luiorpe1@...il.com>
Cc:	lisa@...apiadmin.com, daeseok.youn@...il.com,
	rashika.kheria@...il.com, dan.carpenter@...cle.com,
	veeableful@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: bcm: Qos: fixed braces' coding style

On Wed, Apr 09, 2014 at 01:01:05AM +0200, Luis Ortega wrote:
> Fixed badly placed and unnecessary braces.
> 
> PS: Performed as task 10 of the Eudyptula Challenge.
> 
> Signed-off-by: Luis Ortega <luiorpe1@...il.com>
> ---
>  drivers/staging/bcm/Qos.c | 174 +++++++++++++---------------------------------
>  1 file changed, 48 insertions(+), 126 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
> index 4f31583..4b9ce26 100644
> --- a/drivers/staging/bcm/Qos.c
> +++ b/drivers/staging/bcm/Qos.c
> @@ -33,14 +33,11 @@ static bool MatchSrcIpAddress(struct bcm_classifier_rule *pstClassifierRule, ULO
>  	ulSrcIP = ntohl(ulSrcIP);
>  	if (0 == pstClassifierRule->ucIPSourceAddressLength)
>  		return TRUE;
> -	for (ucLoopIndex = 0; ucLoopIndex < (pstClassifierRule->ucIPSourceAddressLength); ucLoopIndex++)
> -	{
> +	for (ucLoopIndex = 0; ucLoopIndex < (pstClassifierRule->ucIPSourceAddressLength); ucLoopIndex++) 	{

Why the <TAB> before the '{' character?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/