linux-kernel - Re: [PATCH 2/4] dt-bindings: add mtk-timer bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 Apr 2014 20:56:34 +0000
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Matthias Brugger <matthias.bgg@...il.com>,
	linux-kernel@...r.kernel.org
CC:	mark.rutland@....com, andrew@...n.ch, linux-doc@...r.kernel.org,
	thierry.reding@...il.com, heiko.stuebner@...com,
	linux@....linux.org.uk, daniel.lezcano@...aro.org,
	florian.vaussard@...l.ch, sebastian.hesselbarth@...il.com,
	devicetree@...r.kernel.org, jason@...edaemon.net,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	robh+dt@...nel.org, tglx@...utronix.de,
	linux-arm-kernel@...ts.infradead.org, rdunlap@...radead.org,
	silvio.fricke@...il.com, galak@...eaurora.org, olof@...om.net,
	jic23@...nel.org
Subject: Re: [PATCH 2/4] dt-bindings: add mtk-timer bindings

Hi Matthias,
On 09/04/2014 19:45, Matthias Brugger wrote:
> Add binding documentation for the General Porpose Timer driver of
> the Mediatek SoCs.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>
> ---
>  .../bindings/timer/mediatek,mtk-timer.txt          |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> 
> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> new file mode 100644
> index 0000000..db3c836
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> @@ -0,0 +1,19 @@
> +Mediatek MT6598, MT6577 and MT6572 Timers
> +---------------------------------------
> +
> +Required properties:
> +- compatible: Should be "mediatek,mtk6589-timer"
> +- reg: Should contain location and length for timers register.
> +- clock-names : Must include the following entries:
> +  "sysclk" (13 MHz system clock),
> +  "rtcclk" (32 KHz RTC clock).

It would be better to make the clocks mandatory and not their name

Thanks,

Gregory

> +
> +Examples:
> +
> +	timer {
> +		compatible = "mediatek,mtk6589-timer";
> +		reg = <0x10008000 0x80>;
> +		interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>;
> +		clocks = <&system_clk>, <&rtc-clk>;
> +		clock-names = "sysclk", "rtcclk";
> +	};
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/