linux-kernel - Re: [PATCH v7 08/22] Replace xip_truncate_page with dax_truncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Apr 2014 15:07:21 -0400
From:	Matthew Wilcox <willy@...ux.intel.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Matthew Wilcox <matthew.r.wilcox@...el.com>,
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 08/22] Replace xip_truncate_page with dax_truncate_page

On Wed, Apr 09, 2014 at 11:26:35AM +0200, Jan Kara wrote:
>   I thought about this for a while and classical IO, truncation etc. could
> easily work for blocksize < pagesize. And for mmap() you could just use
> pagecache. Not sure if it's worth the complications though. Anyway we
> should decide whether we don't care about blocksize < PAGE_CACHE_SIZE at
> all, or whether we try to make things which can work reasonably easily
> functional. In that case dax_truncate_page() needs some tweaking because it
> currently assumes blocksize == PAGE_CACHE_SIZE.

I think it actually assumes that blocksize <= PAGE_CACHE_SIZE in that
it doesn't contain a loop to iterate over all blocks.  It wouldn't be
hard to fix but I'll just put in a comment noting what needs to be fixed
... I don't think there's going to be a lot of enthusiasm for adding
support for blocksize != PAGE_SIZE / PAGE_CACHE_SIZE.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/