linux-kernel - Re: [PATCH] video: bf54x-lq043fb: fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 15:44:00 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Steven Miao <realmz6@...nel.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<adi-buildroot-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>, <linux-fbdev@...r.kernel.org>,
	Steven Miao <realmz6@...il.com>
Subject: Re: [PATCH] video: bf54x-lq043fb: fix build error

On 12/04/14 04:30, Steven Miao wrote:
> From: Steven Miao <realmz6@...il.com>
> 
> should include linux/gpio.h
> 
> Signed-off-by: Steven Miao <realmz6@...il.com>
> ---
>  drivers/video/bf54x-lq043fb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
> index 42b8f9d..d2b54f1 100644
> --- a/drivers/video/bf54x-lq043fb.c
> +++ b/drivers/video/bf54x-lq043fb.c
> @@ -49,6 +49,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/platform_device.h>
> +#include <linux/gpio.h>

The driver includes <asm/gpio.h>. I think that should be removed, and
<linux/gpio.h> should be used.

Can you also remove the asm/gpio.h in your patch, and see if it compiles
fine?

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)