linux-kernel - RE: [PATCH V3 1/1] X86: Probe for PIC and set legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 17:03:55 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	"H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"JBeulich@...e.com" <JBeulich@...e.com>
Subject: RE: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic
 appropriately



> -----Original Message-----
> From: H. Peter Anvin [mailto:hpa@...or.com]
> Sent: Monday, April 14, 2014 10:02 AM
> To: KY Srinivasan; x86@...nel.org; gregkh@...uxfoundation.org; linux-
> kernel@...r.kernel.org; devel@...uxdriverproject.org; olaf@...fle.de;
> apw@...onical.com; jasowang@...hat.com; tglx@...utronix.de;
> JBeulich@...e.com
> Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic
> appropriately
> 
> On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> > This patch implements the proposal put forth by H. Peter Anvin
> <hpa@...ux.intel.com>.
> >
> > In  version V1 of the patch, I had cleaned up the code based on comments
> from Peter.
> > In  version V2 of the patch, I have addressed additional comments from
> Peter.
> > In this version of the patch, I have addressed Jan's comments
> (JBeulich@...e.com).
> >
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> 
> Technically the patch looks good, but I'm going to have to reject it based on
> the patch description.
> 
> Keep in mind that the above description is the only thing that would go into
> the git repository, and needs to be understandable to someone, say,
> 10 years from now.
> 
> The above says nothing about what the proposal was, and the motivation,
> and the problems it addresses.  So the patch is good, but please write a
> proper, standalone description for it.

Thanks Peter; I will update the description and send it out soon.

K. Y
> 
> Thanks,
> 
> 	-hpa
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/