linux-kernel - Re: [PATCH 2/8] arm/arm64: KVM: Fix line length exceeding 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Apr 2014 09:11:05 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Jungseok Lee <jays.lee@...sung.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
	Catalin Marinas <Catalin.Marinas@....com>,
	'Christoffer Dall' <christoffer.dall@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	'linux-samsung-soc' <linux-samsung-soc@...r.kernel.org>,
	"sungjinn.chung@...sung.com" <sungjinn.chung@...sung.com>,
	'Arnd Bergmann' <arnd@...db.de>,
	"kgene.kim@...sung.com" <kgene.kim@...sung.com>,
	"ilho215.lee@...sung.com" <ilho215.lee@...sung.com>
Subject: Re: [PATCH 2/8] arm/arm64: KVM: Fix line length exceeding 80 characters

On 15/04/14 01:38, Jungseok Lee wrote:
> On Tuesday, April 15, 2014 1:19 AM, Marc Zyngier wrote:
>> On 14/04/14 08:40, Jungseok Lee wrote:
>>> This patch deals with checkpatch complaint as fixing line length
>>> exceeding 80 characters.
>>>
>>> WARNING: line over 80 characters
>>>
>>> Signed-off-by: Jungseok Lee <jays.lee@...sung.com>
>>> Reviewed-by: Sungjinn Chung <sungjinn.chung@...sung.com>
>>> ---
>>>  arch/arm/kvm/mmu.c |    4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index
>>> 80bb1e6..e0d4f24 100644
>>> --- a/arch/arm/kvm/mmu.c
>>> +++ b/arch/arm/kvm/mmu.c
>>> @@ -563,8 +563,8 @@ void kvm_free_stage2_pgd(struct kvm *kvm)
>>>  	kvm->arch.pgd = NULL;
>>>  }
>>>
>>> -static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache *cache,
>>> -			     phys_addr_t addr)
>>> +static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache
>>> +			     *cache, phys_addr_t addr)
>>
>> Please don't. This makes the code unreadable (and no, I don't care about checkpatch ;-).
> 
> Okay. I will drop this patch from the next version.
> 
> It would be good to change stage2_set_pmd_huge function for readability
> if you don't care about checkpatch.

We usually don't change that kind of thing just for the sake of changing
it. It feels like fairly pointless churn. *IF* someone happens to rework
that code, then they're welcome to fix it.

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/