linux-kernel - Re: [PATCH v2] mm: convert some level-less printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Apr 2014 16:58:21 -0700
From:	Mitchel Humpherys <mitchelh@...eaurora.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>, Joe Perches <joe@...ches.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: convert some level-less printks to pr_*

On Mon, Apr 14 2014 at 03:55:26 PM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Thu, 27 Mar 2014 10:54:19 -0700 Mitchel Humpherys <mitchelh@...eaurora.org> wrote:
>>  #include <linux/mm.h>
>>  #include <linux/export.h>
>>  #include <linux/swap.h>
>> @@ -15,6 +17,7 @@
>>  #include <linux/hash.h>
>>  #include <linux/highmem.h>
>>  #include <linux/bootmem.h>
>> +#include <linux/printk.h>
>>  #include <asm/tlbflush.h>
>>  
>>  #include <trace/events/block.h>
>> @@ -34,7 +37,7 @@ static __init int init_emergency_pool(void)
>>  
>>  	page_pool = mempool_create_page_pool(POOL_SIZE, 0);
>>  	BUG_ON(!page_pool);
>> -	printk("bounce pool size: %d pages\n", POOL_SIZE);
>> +	pr_info("bounce pool size: %d pages\n", POOL_SIZE);
>
> This used to print "bounce pool size: N pages" but will now print
> "bounce: bounce pool size: N pages".
>
> It isn't necessarily a *bad* change but perhaps a little more thought
> could be put into it.  In this example it would be better remove the
> redundancy by using 
>
> 	pr_info("pool size: %d pages\n"...);

Yes I noticed this in my boot-test... I'll change it to remove the
redundancy. The others all seem okay.

>
> And all of this should be described and justified in the changelog,
> please.

Will send a v3 shortly. Thanks for your comments.

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/