linux-kernel - Re: [PATCH v2] pwm_lpss: Add support for PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Apr 2014 13:45:48 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Chew Chiau Ee <chiau.ee.chew@...el.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Alan Cox <alan@...ux.intel.com>, linux-pwm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pwm_lpss: Add support for PCI devices

> But if you prefer not to do the split that's fine with me too.

I'd prefer not to split it. The real fix is to have modm_ functions akin
to devm_ but that's another story 8)

> > > > +static const struct pwm_lpss_boardinfo byt_info = {
> > > 
> > > What does byt_ stand for?
> > 
> > Baytrail.
> 
> Okay, that could use a comment since it's not mentioned anywhere else
> and the PCI IDs don't give it away either.

Agreed (it's btw a general Intel thing that devices end up known by a TLA
but it's a good point that they are not entirely well known outside Intel)
> 
> > > > -static int pwm_lpss_probe(struct platform_device *pdev)
> > > > +static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev,
> > > > +			struct resource *r, struct pwm_lpss_boardinfo *info)
> > > 
> > > Indentation is odd here. Please align arguments one subsequent lines
> > > with those of the first.
> > 
> > That doesn't appear to be present in CodingStyle or indeed most of the
> > kernel.
> 
> I'm used to it in the PWM subsystem and I'd like to keep it that way for
> consistency.

Fair enough

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/