linux-kernel - Re: [PATCH] kernfs: fix a subdir count leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Apr 2014 09:19:18 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Jianyu Zhan <nasa4836@...il.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernfs: fix a subdir count leak

On Thu, Apr 17, 2014 at 05:52:10PM +0800, Jianyu Zhan wrote:
> Currently kernfs_link_sibling() increates parent->dir.subdirs before
> adding the node into parent's chidren rb tree.
> 
> Because it is possible that kernfs_link_sibling() couldn't find
> a suitable slot and bail out, this leads to a mismatch between
> elevated subdir count with actual children node numbers.
> 
> This patches fix this problem, by moving the subdir accouting
> after the actual addtion happening.
> 
> Signed-off-by: Jianyu Zhan <nasa4836@...il.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/